#9619: b-coloring of a graph
----------------------------+-----------------------------------------------
   Reporter:  lsampaio      |       Owner:  jason, ncohen, rlm
       Type:  enhancement   |      Status:  needs_work        
   Priority:  major         |   Milestone:  sage-4.5.2        
  Component:  graph theory  |    Keywords:                    
     Author:  lsampaio      |    Upstream:  N/A               
   Reviewer:                |      Merged:                    
Work_issues:                |  
----------------------------+-----------------------------------------------
Changes (by ncohen):

  * status:  needs_review => needs_work


Comment:

 Hello !!!

 It's nice to be reviewing your first patch !

 Well, a few comments about the documentation :

 Unless you define what is a "maximum" b-coloring, the first line of the
 doc does not make sense (I understaned what you mean, but it has to be
 rephrased to be correct). Then it is 'a', not 'the', as there may be many.
 Then this b-cloring may not exist if k is less than Chi, so maybe you
 should even add "if possible".

 by assigning distinct colors to each of its elements => assigning the
 mising color in its neighborhood

 The second paragraph is not clear, perhaps you should first defie what a
 b-vertex is, then rephrase the whole section.

 Define what you mean by "worst case" -> I know what it means, but then
 again I know what b-coloring is.

 NOTE : Instead of copying what I wrote for he Grundy method, perhaps you
 should mention your degree-based bound, to say that it can be assumed to
 be optimal if it reaches this bound (which is less than the max degree of
 course).

 What the hell is this ?

 {{{
 p.add_constraint(Sum(color[v][i] - is_used[i] for v in g.vertices()), max
 = 0)
 }}}

 In the following
 {{{
 p.set_objective(Sum(is_used[i] for i in xrange(k)))
 }}}

 classes = xrange(k)

 And I think that's all there is ! By the way, if you know of a good b
 -coloring-specific example to add in the Examples section... I didn't have
 any inspiration for the Grundy number ;-)

 Nathann

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9619#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to