#9652: Unnecesary and buggy code in arith.py
------------------------+---------------------------------------------------
Reporter: mderickx | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: minor | Milestone:
Component: algebra | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Comment(by mstreng):
Ah yes, python integers. Then perhaps first test if m is a python integer
and call `Integer(m).valuation(*args1, **args2)` if it is and
`m.valuation(*args1, **args2)` otherwise. I think you should leave out the
`m == 0` check because nobody wants `valuation(0, 0)` or `valuation(0,
'whatever')` to give any output.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9652#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.