#9652: Unnecesary and buggy code in arith.py
------------------------+---------------------------------------------------
Reporter: mderickx | Owner: AlexGhitza
Type: defect | Status: needs_work
Priority: minor | Milestone:
Component: algebra | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Comment(by mstreng):
Wasn't the whole point of the extra arguments *args1, **args2 to make the
global function `valuation` also work for power series? It doesn't in the
current Sage, and it wouldn't with John's suggestion, but actually, it
also doesn't with Maarten's patch.
To make it work, remove p. That is, replace "{{{p,*args1, **args2}}}" by
"{{{*args1, **args2}}}" or simply "{{{*args1}}}" both times it occurs in
your patch.
In the EXAMPLES block, you could add
{{{
sage: y = QQ['y'].gen()
sage: valuation(y^3, y)
3
sage: x = QQ[['x']].gen()
sage: valuation(x^2)
2
}}}
This doesn't really belong to the topic of this patch, but as you are
rewriting the function anyway...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9652#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
