#9652: Unnecesary and buggy code in arith.py
------------------------+---------------------------------------------------
Reporter: mderickx | Owner: AlexGhitza
Type: defect | Status: needs_work
Priority: minor | Milestone:
Component: algebra | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Changes (by cremona):
* status: needs_review => needs_work
Comment:
You have added the extra arguments but have not documented them, or given
any examples where they might be used. That's not good!
For the main code, why not do
{{{
try:
return m.valuation(p)
except AttributeError:
pass
try:
return Integer(m).valuation(Integer(p))
except (something):
raise an error
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9652#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
