#5396: Wrapping lcalc library
-------------------------------+--------------------------------------------
Reporter: rishi | Owner: rishi
Type: enhancement | Status: closed
Priority: major | Milestone: sage-4.5.2
Component: number theory | Resolution: fixed
Keywords: lcalc | Author: Rishikesh, Yann Laigle-Chapuy
Upstream: N/A | Reviewer: John Cremona, David Kirkby,
Alex Ghitza
Merged: sage-4.5.2.alpha1 | Work_issues:
-------------------------------+--------------------------------------------
Comment(by fbissey):
Replying to [comment:94 drkirkby]:
> Replying to [comment:93 fbissey]:
>
> > I think it is a remnant from a time where Dave (Kirby) had an
extremely
> > simplified Makefile for lcalc and even then it was a case of
overlinking.
> > Francois
>
> My logic for changing the Makefile fell into 3 reasons I think.
> * The original Makefile had a non-portable gcc option -Wa,-W in an
attempt to suppress warnings from the assembler. That works with the GNU
assembler, but failed with the Sun assembler, as the Sun assembler does
not recognise the -W option.
> * I added -Wall to show the warnings from the code - I think it's good
we see what warnings are generated by the compiler, as it is something to
look at when getting problems.
> * The original Makefile defined the compiler to be "gcc" but if we used
$CC, we could use any compiler.
>
> I doubt I would have changed any linking - if I did, it was probably not
intentionally.
>
> I have not checked this code when CC is defined to be a compiler other
than gcc, but I did fix it to work with any compiler at one point - I hope
a regression has not been introduced.
>
Hi Dave,
the makefile needed some sanity put back into it, especially linker wise.
so that was a job that was needed. I guess my main concern here is:[[BR]]
*lcalc depends on mpfr when it shouldn't.[[BR]]
The rest is just my ramblings about there being an unused variable in
spkg-install - which may lead people to think it is.[[BR]]
Francois
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5396#comment:95>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
