#9845: lcalc doesn't build on cygwin due to missing time.h include
------------------------------------------+---------------------------------
Reporter: was | Owner: GeorgSWeber
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.5.3
Component: build | Keywords:
Author: Mike Hansen, William Stein | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------------------+---------------------------------
Comment(by leif):
Thanks for fixing much of what I mentioned at #9775.
I'm not sure if we should drop the usual "sanity check" at the top of
{{{spkg-install}}}.
(Btw, you missed the "p2" in its top comment.)
The first comment regarding {{{SAGE_DEBUG}}} and the message in the
{{{else}}} part aren't current.
(''"Unset SAGE_DEBUG ..."'' should read ''"Set SAGE_DEBUG to yes ..."''.
Though I'd prefer adding {{{-g}}} independently of that setting, since it
doesn't influence performance, and most other spkgs do so.)
Replacing {{{-lmpir}}} by {{{-lgmp}}} is perhaps a minor issue; using
{{{$MAKE}}} instead of {{{make}}} ({{{$(MAKE)}}} in Lcalc's Makefile
itself, too) IMHO not. Unfortunately, the current {{{spkg/install}}} also
uses {{{make}}} instead of {{{$MAKE}}} unless
{{{SAGE_PARALLEL_SPKG_BUILD=yes}}}, which I consider a bug, since adding
{{{-j}}} is not the only case in which one would set {{{MAKE}}}. One
should never call {{{make}}} inside a Makefile or a script that's executed
through ''some'' "make", because it might be a different one.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9845#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
