#9845: lcalc doesn't build on cygwin due to missing time.h include
----------------------------------------------------------+-----------------
Reporter: was | Owner:
GeorgSWeber
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-4.6
Component: build | Keywords:
Author: Jeroen Demeyer, Mike Hansen, William Stein | Upstream: N/A
Reviewer: Leif Leonhardy | Merged:
Work_issues: |
----------------------------------------------------------+-----------------
Comment(by leif):
Looks as if we no longer need
{{{patches/Lcommandline_elliptic.cc.cygwin}}} (and
{{{patches/Lcommandline_elliptic.cc.cygwin.diff}}}), since this patch
isn't applied.
Mike (or Jeroen, if you can test this), is this Cygwin patch / addition
obsolete:
{{{
#!C
// SAGE -- used below -- needed for Cygwin.
#ifndef llrint
inline long long int llrint (double x)
{
long long int llrintres;
asm
("fistpll %0"
: "=m" (llrintres) : "t" (x) : "st");
return llrintres;
}
#endif
}}}
(It's ''not'' included in the generic patch to
{{{Lcommandline_elliptic.cc}}}, nor upstream.)
Apart from old typos, an obsolete comment regarding {{{SAGE_DEBUG}}}, and
the recent changelog headings lacking the upstream (snapshot?) date
(20100428), I'm quite happy with the new spkg (i.e., the Sage part; the
patched Makefile is still suboptimal, but never mind). :)
If this spkg really contains an upstream snapshot, it is unclear from
SPKG.txt when this was taken / actually put into the spkg.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9845#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
