#9521: Cliquer: Move test commands from spkg-install to spkg-check
------------------------+---------------------------------------------------
Reporter: mpatel | Owner: tbd
Type: defect | Status: new
Priority: minor | Milestone: sage-4.5.3
Component: packages | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Comment(by drkirkby):
See
http://groups.google.com/group/sage-
devel/browse_thread/thread/88102b4c4eadbba7/0100c924f44cf18c?hl=en
I think in this case, it is better to run the test code in {{{spkg-
install}}} on every build, as it takes takes very little time - about 5
seconds to do so on my machine. As such, I suggest we
* Remove the code that actually checks for SAGE_CHECK in spkg-install.
* Run the tests all the time.
* Make spkg-check just return 0 - there's not much point running it
twice.
One issue here is that {{{make}}} exits with 0, even if the test suite
fails. I found this after purposely inducing some failures. It makes me
wonder how many other test suites do this too!
See also #9767 and some comments from myself and Leif.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9521#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
