#9521: Cliquer: Move test commands from spkg-install to spkg-check
------------------------+---------------------------------------------------
Reporter: mpatel | Owner: tbd
Type: defect | Status: new
Priority: minor | Milestone: sage-4.5.3
Component: packages | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Changes (by drkirkby):
* cc: ncohen, leif (added)
Comment:
I've closed #9767 as a duplicate of this one. I've cc'ed Leif, who
commented on #9767 and Nathann as the package maintainer.
I need to respond to Leif's comment on #9767 though:
'''Dave, be warned: You'll hate me if I should review this ({{{spkg-
install}}}, {{{patches/Makefile}}}).'''
I think Leif has unreasonable expectations some times - in particular
#9603, (an iconv change), has resulted in a large number of changes, which
all took time, which could have been better spent addressing other more
serious issues in Sage. The number of changes Leif requested on #9603 was
excessive I feel. Six weeks after the ticket was created to just add
{{{&& [ "x$UNAME" != xHP-UX ]}}}
it is still awaiting a positive review.
I'm not denying the changes Leif requested on #9603 has improved the iconv
package - though I think it was one of the better packages to start with.
I do however think the time spent on it could have been put to more
productive use.
If tickets to add a very small change are going to result in weeks of
iterations, then the changes are not going to be made - at least not by
me.
I am happy to attempt to clean up Cliquer, but on the understanding it
does not become like #9603. I've no desire to spend so much time on
endless small changes.
The only changes I would make to {{{patches/Makefile}}} are Solaris-
specific, as the compiler flags are wrong. (Oh, and I might add the
necessary change to package so it builds on HP-UX, where shared libraries
are .sl and not .so.) But I have no intension of re-writing the whole of
the Makefile.
There's a lot of unnecessary things in {{{spkg-install}}} and I'm happy to
remove them, but I'm not willing to spend weeks on it.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9521#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
