#9871: Update Cliquer to the latest version (1.21) and get the library buiilding
properly on Solaris.
----------------------------+-----------------------------------------------
Reporter: drkirkby | Owner: GeorgSWeber
Type: defect | Status: needs_work
Priority: critical | Milestone: sage-4.6
Component: build | Keywords:
Author: David Kirkby | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Changes (by leif):
* status: needs_review => needs_work
Comment:
See #9833 for at least two reasons.
Note that
{{{
#!sh
make something | tee output_file
}}}
will '''almost always''' have a zero exit status, namely unless {{{tee}}}
fails (or you use {{{bash}}}'s {{{set -o pipefail}}} feature). In fact
{{{make test}}}, i.e. {{{src/testcases}}}, won't exit with a non-zero exit
status in ''all'' cases (but at least ''some''); I would change that and
post the fix upstream (changing some functions from {{{void}}} to return
an {{{int}}}, accumulating the number of failures and returning that at
the end of {{{main()}}}).
There are "of course"^TM^ typos and other things that IMHO have to be
changed ;-) (e.g. using {{{$MAKE}}} instead of {{{make}}}; {{{SAGE_PORT}}}
is not tested but reported to be set, ...).
{{{
#!sh
if [ "x`grep ERROR test.out`" != x ]; then
...
}}}
should e.g. be
{{{
#!sh
if grep -q ERROR test.out; then
...
}}}
...
Btw, I think the spkg's name should have a {{{.p0}}} or {{{.p1}}} in it.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9871#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
