#9871: Update Cliquer to the latest version (1.21) and get the library buiilding
properly on Solaris.
----------------------------+-----------------------------------------------
Reporter: drkirkby | Owner: GeorgSWeber
Type: defect | Status: needs_work
Priority: critical | Milestone: sage-4.6
Component: build | Keywords:
Author: David Kirkby | Upstream: Not yet reported upstream; Will do
shortly.
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Changes (by drkirkby):
* upstream: N/A => Not yet reported upstream; Will do shortly.
Comment:
* There's no need for this to be a .p0 or .p1. It is a new upstream source
code (version 1.21), so the patch level in Sage is removed.
* It is {{{make test}}} which exits with 0, even when I alter the file
{{{src/testcases.c}}} to force tests to fail. A bunch of errors are
reported, then {{{make}}} exits with an exit code of 0.
* {{{make test}}} actually creates a binary called {{{testcases}}} and
then executes that. That exits with 0 in all cases.
* I agree this is an upstream bug in the test code - it should exit with
a non-zero code in the case of errors.
* I'm not trying to test the exit code of {{{tee}}}, but rather
{{{grep}}}.
* I thought {{{grep -q}}} was not portable, but it was {{{cmp -q}}} which
caused a portability issue. So I'll change that.
* I take Leif's point about the fact that there should be no main in a
shared library. But the code works with the compiler options {{{-shared
-Wl,-h,libcliquer.so}}} on Linux and OS X, even though Leif says there's a
main there. I do not want to start re-writing the source code or Makefile
to remove main(). That's an upstream problem. If it was the only way to
fix the text relocations, then I would do it. But simply using the same
compiler options as on other platforms works.
I've created #9870 to address the other issues. I agree there are many,
but I don't want this ticket drag on like #9603.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9871#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
