#9871: Update Cliquer to the latest version (1.21) and get the library buiilding
properly on Solaris.
----------------------------+-----------------------------------------------
   Reporter:  drkirkby      |       Owner:  GeorgSWeber                         
       
       Type:  defect        |      Status:  needs_work                          
       
   Priority:  critical      |   Milestone:  sage-4.6                            
       
  Component:  build         |    Keywords:                                      
       
     Author:  David Kirkby  |    Upstream:  Not yet reported upstream; Will do 
shortly.
   Reviewer:                |      Merged:                                      
       
Work_issues:                |  
----------------------------+-----------------------------------------------

Comment(by leif):

 Replying to [comment:7 jhpalmieri]:
 > > Note that
 {{{
     make something | tee output_file
 }}}
 > > will almost always have a zero exit status
 >
 > The comment in the file suggests that "make test" itself will have a
 zero exit status even if there are failures, and this is why the "tee ..."
 is there at all.

 It '''does''' return 1 on '''some''' errors, but not all. (And I suggested
 to modify {{{testcases.c}}} to return a non-zero value ''on all errors''.
 This is almost trivial.)

 > (This indicates problems with the makefile, I suppose.)  But I may be
 misunderstanding the situation.

 The Makefile does not cause problems; just the comment is not (fully)
 correct.

 > We could also use the "pipestatus" script...

 The correct way would be to redirect the output in the {{{make}}} rule
 itself (with {{{> test.out}}}), or - if you want to see the test running
 live - not redirect it at all. Of course you can also write it to a file
 and use {{{tail [-f]}}}; the written file will usually be deleted after
 the spkg is installed (and tested) anyhow, unless you use {{{sage-spkg -i
 -s ...}}}. So I'd prefer changing the source code and let {{{testcases}}}
 just write to {{{stdout}}} and {{{stderr}}}, s.t. the test output ends up
 in {{{spkg/logs/*.log}}}, as usual.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9871#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to