#8169: include TOPCOM
----------------------------+-----------------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-feature
Component: geometry | Keywords:
Author: Volker Braun | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Comment(by novoselt):
I do not plan to review this ticket since it involves a package, but I'll
allow myself some critical remarks anyway ;-)
1. Module level description is probably not what it was supposed to be
("all vertices of points" does not quite make sense).
1. It would be nice to explain what's the point of using projective
coordinates even when the input is affine.
1. I think it is counter-intuitive that iterating over a point
configuration deals with projective coordinates and over its points -
affine ones. If the default input is affine, I think that default
iterating also should be over affine version with
`points(projective=True)` returning projective coordinates.
1. I personally don't like getting generators as output of methods like
`points` and people less familiar with Python find it quite confusing. So
I think it would be better to return a tuple (or a list, if it is not
cached) and obtain a generator either using something like
`point_generator()` method or by passing an optional argument like
`points(generator=True)`. I understand that generators are more efficient,
but when efficiency is an issue users should be willing to work a little
harder to get them, while for interactive work and new users tuples and
lists are more convenient.
1. I like the interface to restricting type of triangulations, but it
would be nice for each restricting function to have a precise definition
of the corresponding triangulation type.
P.S. My previous attempts to install and use TOPCOM didn't succeed, but
with Volker's package installation was completely painless. So I hope that
it will make its way into Sage in the near future!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8169#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
