#9799: Running "make" in SAGE_ROOT returns the wrong exit code, leading to all
kinds of confusion
------------------------+---------------------------------------------------
Reporter: was | Owner: GeorgSWeber
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-4.6
Component: build | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Comment(by leif):
Not yet tested, but the changes so far look ok to me.
I'd add dependencies on {{{spkg/pipestatus}}}, and perhaps a rule /
receipt that makes sure it is (present and) executable. (More of such
dependencies could be added as well.)
Perhaps substitute
{{{
#!sh
cd spkg && ./pipestatus "./install all 2>&1" "tee -a
../install.log"
}}}
by
{{{
#!sh
spkg/pipestatus "cd spkg && ./install all 2>&1" "tee -a
install.log"
}}}
and, optionally, use a Make variable for {{{spkg/pipestatus}}}.
Some changes we should also make:
* {{{distclean}}} should '''depend''' on {{{clean}}}, not '''call'''
{{{make}}} (if at all, {{{$(MAKE)}}}).
* The dependency of {{{all}}} on {{{build}}} is redundant.
* {{{s/Deleted/Deleting/g}}} or move those messages.
* {{{makefile}}} is not a phony target.
* {{{./sage -b}}} is not consistently performed, and btw. '''after''' the
documentation has been built / updated. Another target and dependency on
that would be better.
* Targets {{{testoptional}}} (logfile {{{testall.log}}}) and
{{{ptestall}}} (logfile {{{ptest.log}}}!) are inconsistent.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9799#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
