#9433: Put more files under revision control.
-----------------------------+----------------------------------------------
   Reporter:  jhpalmieri     |       Owner:  tbd         
       Type:  enhancement    |      Status:  needs_review
   Priority:  major          |   Milestone:  sage-4.6    
  Component:  distribution   |    Keywords:              
     Author:  John Palmieri  |    Upstream:  N/A         
   Reviewer:                 |      Merged:              
Work_issues:                 |  
-----------------------------+----------------------------------------------

Comment(by leif):

 There are some quotes missing at the end of {{{sage-make_devel_packages}}}
 (in the newly included part.)

 Quoting {{{$OPT}}} '''currently''' works, since it is
 {{{
 #!sh
 OPT="pPR"
 }}}
 but it is a bad idea to omit the dash(es) in {{{OPT}}} and prepend it to
 the expansion.

 I.e., it should be
 {{{
 #!sh
 OPT="-pPR"

 ...

 cp $OPT ... # NOT quoted

 ...

 cp -L $OPT ... # also NOT quoted
 }}}

 And I'd suggest renaming {{{OPT}}} to {{{CP_OPTS}}}.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9433#comment:46>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to