#9433: Put more files under revision control.
-----------------------------+----------------------------------------------
Reporter: jhpalmieri | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.6
Component: distribution | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by leif):
Ok, except that {{{hg_script}}} won't work if {{{$SAGE_ROOT}}} contains
spaces, and "sage" should be "Sage" in the messages, the patches and
attached files now look fine (with the one exception below).
In my opinion more exit codes should be checked (of {{{hg}}}, {{{tar}}}
and {{{python}}}), but most of these omissions have been in before, so it
is at least "consistent". ;-) (And some {{{tar}}} operations are verbose,
while others are not. I also think the release date should be UTC or at
least contain the [time and] time zone / UTC offset.)
But {{{sage-upgrade}}} should in any case check that
{{{
#!sh
./pipestatus "sage-spkg $ROOT_REPO 2>&1" "tee -a
$SAGE_ROOT/spkg/logs/$ROOT_REPO.log"
}}}
worked before calling {{{./install}}}.
I also wonder if this shouldn't (yet) be
{{{
#!sh
./pipestatus "sage-spkg $ROOT_REPO 2>&1" "tee -a
\"$SAGE_ROOT\"/spkg/logs/$ROOT_REPO.log"
}}}
(Not tested; the side effects of {{{pipestatus}}} are quite weird.)
I haven't yet applied the patches or fully checked the functionality; at
least I didn't find errors in the latest attachments. :)
Btw, why aren't base packages subject to upgrading? (I would have expected
the root spkg there.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9433#comment:49>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
