#9433: Put more files under revision control.
-----------------------------+----------------------------------------------
Reporter: jhpalmieri | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.6
Component: distribution | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by jhpalmieri):
Replying to [comment:49 leif]:
> Ok, except that {{{hg_script}}} won't work if {{{$SAGE_ROOT}}} contains
spaces,
Since this script only gets run once, by the release manager when this
ticket is merged, and since it doesn't get distributed with Sage, I'm not
going to worry about it. When Sage works with spaces in the path, if this
hasn't been merged yet, I can fix it then.
> and "sage" should be "Sage" in the messages,
I'll fix that. You mean messages like "Error building the sage source
code package" or "Error copying sage root repository", right?
> In my opinion more exit codes should be checked (of {{{hg}}}, {{{tar}}}
and {{{python}}}), but most of these omissions have been in before, so it
is at least "consistent". ;-) (And some {{{tar}}} operations are verbose,
while others are not. I also think the release date should be UTC or at
least contain the [time and] time zone / UTC offset.)
>
> But {{{sage-upgrade}}} should in any case check that
{{{
#!sh
./pipestatus "sage-spkg $ROOT_REPO 2>&1" "tee -a
$SAGE_ROOT/spkg/logs/$ROOT_REPO.log"
}}}
> worked before calling {{{./install}}}.
You're right, I thought about this before, but didn't do it.
> Btw, why aren't base packages subject to upgrading? (I would have
expected the root spkg there.)
I'm not sure what you mean by "base packages". The {{{sage-upgrade}}}
script will certainly upgrade the sage-root spkg. Let's see, the sage-
update script will download any new spkg, including any sage-root spkg.
Then it gets installed in sage-upgrade before the other spkgs, in case it
changes deps or spkg/install.
Should I create an upgrade path on sage.math? I may wait a day or two for
the disk situation to settle down...
Re the "pipestatus" command, I'm going to leave it as is and see what
happens during testing. (When I tested a month ago or so, the sage-root
spkg got upgraded, and I vaguely remember checking that the log file had
the right name, but I'll test again.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9433#comment:53>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
