#4836: pari types getattr() function ugly and inefficient
------------------------------+---------------------------------------------
Reporter: cremona | Owner: was
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.6
Component: interfaces | Keywords: pari gp getattr
Author: Jeroen Demeyer | Upstream: N/A
Reviewer: John Cremona | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by cremona):
* status: needs_review => positive_review
* reviewer: => John Cremona
Comment:
Patch applies fine to 4.6.alpha1 + #9898 + #9753.
Tests all pass on a 32-bit machine.
In the patch:
1. Is the first line of docstring of ideallist() a typo: "Vector of
vectors `L` of all idealstar of all ideals of `norm <= bound`. " ? Or are
you using "idealstar" in a PARI-technical sense of "ideal structure with
extra data?
2. Can you explain the quotes in the patch to maps.py (e.g. "'x")
3. I would not have minded if you had removed my old smallest_integer
code instead of commenting it out!
Positive review! Thanks for doing this. (Did you deal with all
occurrences of getattr()?)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4836#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
