#4836: pari types getattr() function ugly and inefficient
------------------------------+---------------------------------------------
Reporter: cremona | Owner: was
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.6
Component: interfaces | Keywords: pari gp getattr
Author: Jeroen Demeyer | Upstream: N/A
Reviewer: John Cremona | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by jdemeyer):
Replying to [comment:14 cremona]:
> Patch applies fine to 4.6.alpha1 + #9898 + #9753.
>
> Tests all pass on a 32-bit machine.
>
> In the patch:
>
> 1. Is the first line of docstring of ideallist() a typo: "Vector
of vectors `L` of all idealstar of all ideals of `norm <= bound`. " ? Or
are you using "idealstar" in a PARI-technical sense of "ideal structure
with extra data?
Yes, it is meant in that sense. That help is copied from the PARI help.
> 2. Can you explain the quotes in the patch to maps.py (e.g. "'x")
It means the actual *variables* {{{x}}} and {{{y}}}, even if {{{x}}} and
{{{y}}} have been assigned to something. For example, try the following
in {{{gp}}}:
{{{
gp> x = 10
%1 = 10
gp> x
%2 = 10
gp> 'x
%3 = x
}}}
> 3. I would not have minded if you had removed my old
smallest_integer code instead of commenting it out!
Well, it doesn't hurt to leave to code for now, in case something breaks.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4836#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
