#9972: Add toric lattice morphisms
----------------------------------+-----------------------------------------
Reporter: novoselt | Owner: mhampton
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.6
Component: geometry | Keywords:
Author: Andrey Novoseltsev | Upstream: N/A
Reviewer: Volker Braun | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Comment(by vbraun):
I like the functionality, but I'm confused about the name. Is this
supposed to be a `ToricLatticeMorphism` or a `FanMorphism`? I am thinking
that it would be good to split those apart, and perhaps make the latter
inherit from the former.
`ToricLatticeMorphism.make_compatible_with(fan)` doesn't make the morphism
compatible with the fan, it is the other way round. So it should be either
`fan.make_compatible_with(toric_morphism)` or, say,
`ToricLatticeMorphism.subdivide_domain(domain_fan,codomain_fan)`. Or see
below.
Another functionality that I would like to have is to figure out the image
fan from the lattice morphism and the domain. How about the following
proposal:
1. separate `ToricLatticeMorphism` and `FanMorphism`.
2. `FanMorphism(lattice_hom, domain=Fan, codomain=Fan)` constructs the
fan morphism. If `lattice_hom` is a matrix the corresponding
`ToricLatticeMorphism` is constructed automatically. Raises `ValueError`
if the fans are not compatible.
3. `FanMorphism(lattice_hom, domain=Fan)` constructs the image fan and
uses it as codomain. Raise `ValueError` if not possible.
4. `FanMorphism(lattice_hom, domain=Fan, codomain=Fan, subdivide=True)`
will subdivide the domain fan as necessary.
Let me know what you think & I'd be happy to help, of course!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9972#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
