#9972: Add toric lattice morphisms
-------------------------------------+--------------------------------------
Reporter: novoselt | Owner: mhampton
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.6
Component: geometry | Keywords:
Author: Andrey Novoseltsev | Upstream: N/A
Reviewer: Volker Braun | Merged:
Work_issues: switch to FanMorphism |
-------------------------------------+--------------------------------------
Comment(by vbraun):
Patch is attached. I removed 'cohomology_class' from
`Cone_of_toric_variety` to make sure that I got all occurrences, but tried
to make as few other changes in that area as possible. Can you try to put
my patch at the bottom of this ticket's queue?
I added an overriding method `Cone_of_fan.is_equivalent` (see the "TODO"
comment) that you should uncomment after removing the enhanced cones.
The `CohomologyRing._element_constructor_` now accepts cones as well. For
the other issue, you should have complained that `divisor_group` returns
the non-toric divisor group and only `toric_divisor_group` should accept
cones ;-) The latter already works as it should.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9972#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
