#9972: Add toric lattice morphisms
-------------------------------------+--------------------------------------
Reporter: novoselt | Owner: mhampton
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.6
Component: geometry | Keywords:
Author: Andrey Novoseltsev | Upstream: N/A
Reviewer: Volker Braun | Merged:
Work_issues: switch to FanMorphism |
-------------------------------------+--------------------------------------
Changes (by novoselt):
* status: needs_info => needs_work
* work_issues: => switch to FanMorphism
Comment:
OK, I wanted to avoid "compatibility check by exception" but I can live
with it ;-) How about this:
1. Move `cone.cohomology_class` functionality to the element constructor
of cohomology ring (I actually think this is the best and the most clear
way there can be.) Can you perhaps make a patch for this change since it
involves mostly your code?
1. Get rid of `Cone_of_toric_variety` (that's my part so I can do this).
This raises a question whether `EnhancedCone/Fan` should survive at all.
One option is to put `_` in front so that they disappear from the
documentation.
1. Make `FanMorphism` work as you have described, including informative
error message.
1. See if there is then any point in having `ToricLatticeMorphism` at
all.
1. No changes to cones, all (pre)images are computed/stored by morphisms.
Which is probably also the cleanest way to do it.
I am also OK with `ToricMorphism` for equivariant ones. I'll see what name
should fit nicely with existing classes for affine/projective morphisms
for a "non-toric morphism between toric varieties."
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9972#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
