#10105: cremona_letter_code does not handle erroneous input gracefully.
-------------------------------+--------------------------------------------
Reporter: drkirkby | Owner: cremona
Type: defect | Status: new
Priority: minor | Milestone: sage-4.6
Component: elliptic curves | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Comment(by cremona):
You are quite right: any input not a non-negative integer is bad, and the
code should check this.
It's also true that this function need not be in the global namespace,
it's a technical helper function. so in sage/databases/all.py:
{{{
from cremona import CremonaDatabase, \
cremona_letter_code, parse_cremona_label, \
old_cremona_letter_code, is_optimal_id
}}}
only the first import should be there. For another ticket perhaps, since
certainly removing those global imports will result in lots of local ones
being needed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10105#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
