#10105: cremona_letter_code does not handle erroneous input gracefully.
-------------------------------+--------------------------------------------
Reporter: drkirkby | Owner: cremona
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.6
Component: elliptic curves | Keywords: databases
Author: John Cremona | Upstream: N/A
Reviewer: David Kirkby | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Changes (by drkirkby):
* reviewer: => David Kirkby
Comment:
Thanks John. I think its third time lucky, as I can't find any faults with
this.
I've tried every combination of junk I can think of to throw at
{{{cremona_letter_code()}}}, but it always behaves properly. It will not
accept any augments except one non-negative integer.
It passes the doctest
{{{
drkir...@hawk:~/sage-4.6.alpha3$ ./sage -t -long
devel/sage/sage/databases/cremona.py
sage -t -long "devel/sage/sage/databases/cremona.py"
[3.9 s]
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 3.9 seconds
}}}
However, I don't feel my Python skills are sufficient to press the
positive review, so I hope someone with more Python knowledge will look at
this. But I can't fault it myself.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10105#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
