#10105: cremona_letter_code does not handle erroneous input gracefully.
-------------------------------+--------------------------------------------
Reporter: drkirkby | Owner: cremona
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.6
Component: elliptic curves | Keywords: databases
Author: John Cremona | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Comment(by cremona):
Replying to [comment:5 drkirkby]:
> I'll test the patch.
>
> A minor point, but there is a grammatical error - the word ''are'' is
missing.
>
> Cremona letter codes ''are'' only defined for non-negative integers
>
> Dave
That was an abbreviated message rather than a mistake, but I have
corrected it now.
(Replacement patch in a few seconds.)
And I too am still building alpha3 so this was made for alpha2, though I
think it highly unlikely that will change matters.
By the way, the only places where this function is used outside its own
file are in modular/abvar/abvar and .../abvar_newform, where it is
explicitly imported.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10105#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
