#10182: long doctest wrongly tagged "# long" instead of "#long time"
-----------------------+----------------------------------------------------
   Reporter:  cremona  |       Owner:  mvngu           
       Type:  defect   |      Status:  needs_review    
   Priority:  minor    |   Milestone:  sage-4.6.1      
  Component:  doctest  |    Keywords:  doctest long tag
     Author:           |    Upstream:  N/A             
   Reviewer:           |      Merged:                  
Work_issues:           |  
-----------------------+----------------------------------------------------

Comment(by benjaminfjones):

 (first time reviewer)
 I checked the patch using sage-4.6 built from source on Mac OS X 10.6.4).
 It looks good. I Checked the patched file plot.py, that looks good too. I
 checked the test times before and after patching:

 Before patch:
 sage -t  "devel/sage/sage/plot/plot.py"
          [61.5 s]
 sage -t --long "devel/sage/sage/plot/plot.py"
          [61.9 s]

 After patch:
 sage -t  "devel/sage/sage/plot/plot.py"
          [51.2 s]
 sage -t --long "devel/sage/sage/plot/plot.py"
          [61.7 s]

 So the changes had the desired effect, but I'll let someone more
 experienced look this over and change the ticket status if appropriate.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10182#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to