#10182: long doctest wrongly tagged "# long" instead of "#long time"
------------------------------+---------------------------------------------
Reporter: cremona | Owner: mvngu
Type: defect | Status: positive_review
Priority: minor | Milestone: sage-4.6.1
Component: doctest | Keywords: doctest long tag
Author: damek | Upstream: N/A
Reviewer: Benjamin Jones | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => positive_review
* reviewer: => Benjamin Jones
* author: => damek
Comment:
Sorry for my confusing post above; it certainly makes sense to fix all
three instances in this one file, which is exactly what the third patch
does.
I checked that the patch applies cleanly to 4.6.1.alpha0 (it does) and
that the before & after timings are similar to those reported by Benjamin.
I did not test any other files; since no actual code was touched that is
not necessary.
Hence a positive review! I am putting "damek" as author as I don't know
his/her real name (it is not at http://trac.sagemath.org/sage_trac) and
Benjamin Jones as reviewer.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10182#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
