#10187: Update ecl and maxima
-------------------------------------------------------------------------------+
Reporter: vbraun
| Owner: tbd
Type: defect
| Status: needs_work
Priority: major
| Milestone: sage-4.6.1
Component: packages
| Keywords:
Author: Volker Braun, David Kirkby
| Upstream: Workaround found; Bug reported upstream.
Reviewer: Karl-Dieter Crisman, David Kirkby, Volker Braun, Leif Leonhardy
| Merged:
Work_issues:
|
-------------------------------------------------------------------------------+
Comment(by leif):
Replying to [comment:99 drkirkby]:
> === My ECL package ===
>
> * I don't see anything wrong with the way CXXFLAGS/CFLAGS is handled in
the ECL package. It looks OK to me. It might not be 100% necessary, but in
general we should set these flags and hope the package follows this.
If you change
{{{
#!sh
if [ "x$SAGE_DEBUG" = xyes ] ; then
CFLAGS="$CFLAGS -g -O0"
CXXFLAGS="$CXXFLAGS -g -O0"
else
CFLAGS="$CFLAGS -g -O2"
CXXFLAGS="$CXXFLAGS -g -O2"
fi
}}}
to
{{{
#!sh
if [ "x$SAGE_DEBUG" = xyes ] ; then
CFLAGS="$CFLAGS -g -O0"
CXXFLAGS="$CXXFLAGS -g -O0"
else
CFLAGS="-g -O2 $CFLAGS"
CXXFLAGS="-g -O2 $CXXFLAGS"
fi
}}}
and add a comment that neither `CXX` nor `CXXFLAGS` are used within Sage /
the way we configure / install ECL, I'm ok with your package.
In the long run, `CFLAG64` and `CXXFLAG64` should be set to their defaults
(if empty) in (e.g.) `sage-env`.
You could remove the superfluous
{{{
#!sh
set +e
}}}
The comment
{{{
#!sh
# 'export MAKE='make -j n' where n>1, breaks ECL builds, so unset make
}}}
isn't up-to-date (since we do no longer `unset MAKE`).
I have no idea what
{{{
#!sh
# We clear MAKEFLAGS to fix building multiple spkgs in parallel on OS X.
export MAKEFLAGS=
}}}
is (now) intended to fix; `MAKE="$MAKE -j1"` should be sufficient. If it
was really necessary on Darwin, it should only be done on Darwin, since it
clears other `MAKEFLAGS` unrelated to parallel builds as well.
The following comment is a bit weird; `ln -sf ...` should do the right
thing (without `rm`).
{{{
#!sh
# Create symbolic link to lib/ecl-version directory.
# This is important when the Sage install is moved.
cd "$SAGE_LOCAL/lib/" && rm -f ecl && ln -s ecl-* ecl
}}}
The following won't work with spaces in `$SAGE_LOCAL` (currently a minor
issue):
{{{
#!sh
CPPFLAGS="$CPPFLAGS -I$SAGE_LOCAL/include"
LDFLAGS="$LDFLAGS -L$SAGE_LOCAL/lib"
}}}
(We could instead use `--with-gmp-prefix="$SAGE_LOCAL"`, and similar for
the Boehm garbage collector...)
Perhaps add a comment to `SPKG.txt` that the ''included'' Boehm GC is used
on MacOS X (only), if this is still the case. (I think it is; ECL used to
assume ''any'' other Boehm GC found on MacOS X must be Fink's broken one,
so always used its own there.)
I don't agree with the comment regarding the removal of the GMP source
tree; leaving just `install-sh` there is totally safe, without requiring
any patch.
----
I'm ok with the Maxima spkg (IIRC ;-) ).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10187#comment:100>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
