#10303: clean up sage-check-64 and use of SAGE64
--------------------------------------------+-------------------------------
Reporter: jhpalmieri | Owner: GeorgSWeber
Type: defect | Status: positive_review
Priority: minor | Milestone: sage-4.6.1
Component: build | Keywords: 64
Author: John Palmieri | Upstream: N/A
Reviewer: David Kirkby, Leif Leonhardy | Merged:
Work_issues: |
--------------------------------------------+-------------------------------
Comment(by jhpalmieri):
Replying to [comment:49 jdemeyer]:
> Replying to [comment:48 jhpalmieri]:
> > You're holding up the patch because of this?
>
> No, I'm not.
Changing it "needs work" instead of merging it seems like holding it up...
> Of course, the release manager can do it, but I think it is better that
I point out these minor issues to the aurhors
Sure.
> and that they fix them
Why? If it's trivial to fix, why does it matter who does it? If you
insist that the authors do it every time, you're adding needless
bureaucracy. If anyone notices a problem that's trivial to fix, they
should just do it. Sage is not run by the French government: it is not
supposed to be governed by rigid bureaucratic rules, but instead by common
sense whenever possible. Leif, the same goes for you: if you see a
problem like missing line breaks in the commit message, and if it seems
clear that other work on the ticket has stopped, why not just fix it?
That seems more productive than waiting until someone else (like the
release manager) notices it and then commenting "I was aware of that."
> (does it matter if it takes 10 hours?).
If it's the 10 hours during which a version is released, yes. But 10
hours is just an example. What if I were on vacation or at a conference
with little or no internet access, or swamped with grading or research or
other issues, and couldn't get to this for a week or two? This particular
ticket is not very important, so if it had missed being included in the
upcoming version of Sage, no big deal, but why incur a possible long delay
and require the author to fix it?
> Imagine you have 10 tickets with various of these minor issues.
I don't have to imagine it, I've been release manager and fixed a number
of issues like this (for example, commit messages without the ticket
number). I may have then posted to the ticket what the problem was, but I
took care of fixing it myself.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10303#comment:50>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
