#10427: cloning is broken on Solaris
-----------------------------+----------------------------------------------
   Reporter:  jhpalmieri     |       Owner:  drkirkby        
       Type:  defect         |      Status:  needs_review    
   Priority:  minor          |   Milestone:  sage-4.6.1      
  Component:  solaris        |    Keywords:  Solaris ln posix
     Author:  John Palmieri  |    Upstream:  N/A             
   Reviewer:                 |      Merged:                  
Work_issues:                 |  
-----------------------------+----------------------------------------------

Comment(by leif):

 Replying to [comment:4 jhpalmieri]:
 > Other comments: I'm not touch sage-sage beyond what's required for this
 ticket, regardless of the state of the rest of that file.

 Well, you did more than would have been necessary to fix the ticket's
 issue. :)

 Patch in principle looks good to me; just one question: Is the "blank"
 `echo` line at the beginning intentional?

 (Dave prefers `[ -z "$SAGE_LOCAL" ]`, i.e. not comparing against empty
 strings. I don't mind, though I also prefer `-z` and `-n`.)

 The comment(s) regarding `ln -snf` is a bit misleading, since we never
 want to delete (or overwrite) the target, which is `sage-<branch>`, but
 the link to it, `sage`.


 [[BR]]
 > Any issues with devel/sage/spkg-install should be dealt with elsewhere.

 I just mentioned it because it does similar (but is "Solaris-safe" in that
 way).

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10427#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to