#10427: cloning is broken on Solaris
------------------------------+---------------------------------------------
Reporter: jhpalmieri | Owner: drkirkby
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-4.6.1
Component: solaris | Keywords: Solaris ln -snf posix symbolic
link dereference
Author: John Palmieri | Upstream: N/A
Reviewer: Leif Leonhardy | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by jhpalmieri):
* status: positive_review => needs_work
Comment:
Replying to [comment:5 leif]:
> Replying to [comment:4 jhpalmieri]:
> > Other comments: I'm not touch sage-sage beyond what's required for
this ticket, regardless of the state of the rest of that file.
>
> Well, you did more than would have been necessary to fix the ticket's
issue. :)
>
> Patch in principle looks good to me; just one question: Is the "blank"
`echo` line at the beginning intentional?
Not really, I just copied the whole block of code from somewhere else,
although if there is a problem like this with the script, having a blank
line before the error message can make it stand out more, especially if it
comes after many other lines of output.
> (Dave prefers `[ -z "$SAGE_LOCAL" ]`, i.e. not comparing against empty
strings. I don't mind, though I also prefer `-z` and `-n`.)
I can change it to `-z`.
> The comment(s) regarding `ln -snf` is a bit misleading, since we never
want to delete (or overwrite) the target, which is `sage-<branch>`, but
the link to it, `sage`.
Oh, I see, on some platforms (e.g. OS X and Solaris), the man page for ln
refers to the link as the "target" and the existing file being linked as
the "source", while on other platforms (e.g. at least some linux
platforms), the existing file is called the "target" and the link is
called "LINK NAME". Since I've been looking at the Solaris man page when
dealing with this, that terminology must have stuck in my head. So the
problem is that the terminology in the man pages wildly inconsistent, and
so the word "target" should be avoided completely.
> > Any issues with devel/sage/spkg-install should be dealt with
elsewhere.
>
> I just mentioned it because it does similar (but is "Solaris-safe" in
that way).
Right. I'd already searched through the rest of local/bin/sage-*, and
also the scripts in spkg for other instances of "ln".
------
If you have time to review it again, I would appreciate it.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10427#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
