#9434: Stop greping for a non-existent sage-banner
---------------------------------+------------------------------------------
Reporter: drkirkby | Owner: drkirkby
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.6.1
Component: build | Resolution:
Keywords: scripts VERSION.txt | Author: John Palmieri
Upstream: N/A | Reviewer: Jeroen Demeyer, David Kirkby
Merged: sage-4.6.1.alpha3 | Work_issues: Fix download of VERSION.txt
---------------------------------+------------------------------------------
Changes (by jhpalmieri):
* status: needs_work => needs_review
Comment:
Replying to [comment:50 jdemeyer]:
> 1) Why not rename/copy the file "SAGE_ROOT/spkg/standard/.VERSION.txt"
to "SAGE_ROOT/VERSION.txt" in `spkg-upgrade`? That way, there will be a
top-level `VERSION.txt` just like one would have with a clean build.
I agree that the top-level VERSION.txt should be the same as
spkg/standard/VERSION.txt, which was not the case in my previous patch.
I've fixed that so that once the top-level file is created, it's copied to
spkg/standard. (The top-level file contains upgrade information, and
since upgrade info may be helpful in tracking down problems, we should
keep that one rather than the downloaded one.)
> 2) I would ''not'' make the file hidden, I don't think there is a
problem with a file `spkg/standard/VERSION.txt`.
Okay.
> 3) I would copy using `cp -p`.
Good idea.
I'm attaching two patches, one of which just fixes these issues. The
other patch, which could be applied on top of the others, does a little
miscellaneous clean-up in sage-update, using `os.path.join(x,y)` instead
of `"%s/%s" %(x,y)`. Feel free to ignore the second patch completely; it
is entirely optional right now.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9434#comment:51>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
