#10618: Include David Perkinson's sandpile module in the sage library
-------------------------------------------------+--------------------------
Reporter: mhampton | Owner: jason, ncohen,
rlm
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.6.2
Component: graph theory | Keywords: abelian
sandpile model
Author: David Perkinson, Marshall Hampton | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-------------------------------------------------+--------------------------
Comment(by mhampton):
OK, all tests pass for me now and the coverage is 100%.
The only problem that I see now is how to deal with namespace issues. I
think classes like "Divisor" have too general a name to get imported into
Sage at the top level, which is what this patch currently does. I see
three alternatives at least:
1) Rename functions and classes to be clearly sandpile specific. E.g.,
rename the Divisor class to something like SandpileDivisor.
2) Don't import this module into the namespace at all, so users would have
to do:
{{{
sage: from sage.sandpiles import *
}}}
themselves.
3) Import the module in its own namespace, so for instance you would have
to do:
{{{
sage: S = sandpiles.complete_sandpile(4)
}}}
I would rank these as 1 > 2 > 3, but this is an important decision since
it will be a pain to change later.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10618#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
