#10618: Include David Perkinson's sandpile module in the sage library
-------------------------------------------------+--------------------------
Reporter: mhampton | Owner: jason, ncohen,
rlm
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.6.2
Component: graph theory | Keywords: abelian
sandpile model
Author: David Perkinson, Marshall Hampton | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-------------------------------------------------+--------------------------
Comment(by wdj):
Replying to [comment:6 mhampton]:
> OK, all tests pass for me now and the coverage is 100%.
>
Not for me:
{{{
sage -t -force_lib "devel/sage/sage/sandpiles/sandpile.py"
**********************************************************************
File
"/Users/wdj/sagefiles/sage-4.6.1.rc1/devel/sage/sage/sandpiles/sandpile.py",
line 5173:
sage: for p in P:
sum([partition_sandpile(S, i).betti(verbose=False)[-Integer(1)] for
i in p])
Exception raised:
Traceback (most recent call last):
File "/Users/wdj/sagefiles/sage-4.6.1.rc1/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/Users/wdj/sagefiles/sage-4.6.1.rc1/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/Users/wdj/sagefiles/sage-4.6.1.rc1/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_160[3]>", line 1, in <module>
for p in P:###line 5173:
sage: for p in P:
NameError: name 'P' is not defined
**********************************************************************
1 items had failures:
1 of 5 in __main__.example_160
***Test Failed*** 1 failures.
}}}
This sort of failure occurs on both a 10.6.6 imac and an ubuntu machine.
> The only problem that I see now is how to deal with namespace issues.
> I think classes like "Divisor" have too general a name to get imported
into
> Sage at the top level, which is what this patch currently does.
> I see three alternatives at least:
>
> 1) Rename functions and classes to be clearly sandpile specific.
> E.g., rename the Divisor class to something like SandpileDivisor.
>
I agree. I actually suggested this when David P was asking for suggestions
years ago in reply to his post asking for comments on a first version.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10618#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
