#10618: Include David Perkinson's sandpile module in the sage library
-------------------------------------------------+--------------------------
   Reporter:  mhampton                           |       Owner:  jason, ncohen, 
rlm    
       Type:  enhancement                        |      Status:  needs_info     
       
   Priority:  major                              |   Milestone:  sage-4.6.2     
       
  Component:  graph theory                       |    Keywords:  abelian 
sandpile model
     Author:  David Perkinson, Marshall Hampton  |    Upstream:  N/A            
       
   Reviewer:                                     |      Merged:                 
       
Work_issues:                                     |  
-------------------------------------------------+--------------------------
Changes (by wdj):

  * status:  needs_review => needs_info


Comment:

 This looks good in the sense that the docstrings do not fail after 4ti2
 (and glpk) is added.

 I am willing to give this a positive review. However, there are still some
 problems with the docstrings - (a) the naming issue mentioned above, (b)
 one date in the AUTHOR field has the wrong year, (c) the instructions on
 installing 4ti2 lead to the old package which does not install.

 Should these be fixed in a separate ticket?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10618#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to