#10604: Rewrite diagonal matrix constructor
------------------------------+---------------------------------------------
Reporter: rbeezer | Owner: ddrake
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-4.6.2
Component: linear algebra | Keywords:
Author: Rob Beezer | Upstream: N/A
Reviewer: Dan Drake | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by jdemeyer):
* status: positive_review => needs_work
Comment:
There are some doctest failures:
{{{
sage -t "devel/sage/sage/rings/number_field/number_field_ideal.py"
**********************************************************************
File
"/usr/local/src/sage-4.6.2.alpha1/devel/sage/sage/rings/number_field/number_field_ideal.py",
line 2304:
sage: I.ideallog(a + 7, [1+a, 2])
Exception raised:
Traceback (most recent call last):
File "/usr/local/src/sage-4.6.2.alpha1/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/usr/local/src/sage-4.6.2.alpha1/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/usr/local/src/sage-4.6.2.alpha1/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_71[11]>", line 1, in <module>
I.ideallog(a + Integer(7), [Integer(1)+a, Integer(2)])###line
2304:
sage: I.ideallog(a + 7, [1+a, 2])
File "/usr/local/src/sage-4.6.2.alpha1/local/lib/python/site-
packages/sage/rings/number_field/number_field_ideal.py", line 2357, in
ideallog
mat = mat.stack( diagonal_matrix(ZZ, invs).augment(zero_matrix(ZZ,
len(invs), len(gens))))
File "matrix_integer_dense.pyx", line 4426, in
sage.matrix.matrix_integer_dense.Matrix_integer_dense.stack
(sage/matrix/matrix_integer_dense.c:32907)
TypeError: Cannot convert
sage.matrix.matrix_integer_sparse.Matrix_integer_sparse to
sage.matrix.matrix_integer_dense.Matrix_integer_dense
**********************************************************************
File
"/usr/local/src/sage-4.6.2.alpha1/devel/sage/sage/rings/number_field/number_field_ideal.py",
line 2306:
sage: I.ideallog(a + 7, [2, 1+a])
Exception raised:
Traceback (most recent call last):
File "/usr/local/src/sage-4.6.2.alpha1/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/usr/local/src/sage-4.6.2.alpha1/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/usr/local/src/sage-4.6.2.alpha1/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_71[12]>", line 1, in <module>
I.ideallog(a + Integer(7), [Integer(2), Integer(1)+a])###line
2306:
sage: I.ideallog(a + 7, [2, 1+a])
File "/usr/local/src/sage-4.6.2.alpha1/local/lib/python/site-
packages/sage/rings/number_field/number_field_ideal.py", line 2357, in
ideallog
mat = mat.stack( diagonal_matrix(ZZ, invs).augment(zero_matrix(ZZ,
len(invs), len(gens))))
File "matrix_integer_dense.pyx", line 4426, in
sage.matrix.matrix_integer_dense.Matrix_integer_dense.stack
(sage/matrix/matrix_integer_dense.c:32907)
TypeError: Cannot convert
sage.matrix.matrix_integer_sparse.Matrix_integer_sparse to
sage.matrix.matrix_integer_dense.Matrix_integer_dense
**********************************************************************
File
"/usr/local/src/sage-4.6.2.alpha1/devel/sage/sage/rings/number_field/number_field_ideal.py",
line 2313:
sage: J.ideallog(5+2*b, [u, v], check=True)
Exception raised:
Traceback (most recent call last):
File "/usr/local/src/sage-4.6.2.alpha1/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/usr/local/src/sage-4.6.2.alpha1/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/usr/local/src/sage-4.6.2.alpha1/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_71[17]>", line 1, in <module>
J.ideallog(Integer(5)+Integer(2)*b, [u, v], check=True)###line
2313:
sage: J.ideallog(5+2*b, [u, v], check=True)
File "/usr/local/src/sage-4.6.2.alpha1/local/lib/python/site-
packages/sage/rings/number_field/number_field_ideal.py", line 2357, in
ideallog
mat = mat.stack( diagonal_matrix(ZZ, invs).augment(zero_matrix(ZZ,
len(invs), len(gens))))
File "matrix_integer_dense.pyx", line 4426, in
sage.matrix.matrix_integer_dense.Matrix_integer_dense.stack
(sage/matrix/matrix_integer_dense.c:32907)
TypeError: Cannot convert
sage.matrix.matrix_integer_sparse.Matrix_integer_sparse to
sage.matrix.matrix_integer_dense.Matrix_integer_dense
**********************************************************************
File
"/usr/local/src/sage-4.6.2.alpha1/devel/sage/sage/rings/number_field/number_field_ideal.py",
line 2318:
sage: I.ideallog(a + 7, [2])
Expected:
Traceback (most recent call last):
...
ValueError: Given elements do not generate unit group -- they generate
a subgroup of index 36
Got:
Traceback (most recent call last):
File "/usr/local/src/sage-4.6.2.alpha1/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/usr/local/src/sage-4.6.2.alpha1/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/usr/local/src/sage-4.6.2.alpha1/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_71[18]>", line 1, in <module>
I.ideallog(a + Integer(7), [Integer(2)])###line 2318:
sage: I.ideallog(a + 7, [2])
File "/usr/local/src/sage-4.6.2.alpha1/local/lib/python/site-
packages/sage/rings/number_field/number_field_ideal.py", line 2357, in
ideallog
mat = mat.stack( diagonal_matrix(ZZ, invs).augment(zero_matrix(ZZ,
len(invs), len(gens))))
File "matrix_integer_dense.pyx", line 4426, in
sage.matrix.matrix_integer_dense.Matrix_integer_dense.stack
(sage/matrix/matrix_integer_dense.c:32907)
TypeError: Cannot convert
sage.matrix.matrix_integer_sparse.Matrix_integer_sparse to
sage.matrix.matrix_integer_dense.Matrix_integer_dense
**********************************************************************
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10604#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
