#9238: J. Gutow's update to Jmol in the notebook...
------------------------------------------------+---------------------------
Reporter: gutow | Owner: gutow
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.6.2
Component: notebook | Keywords:
Author: Jonathan Gutow | Upstream: N/A
Reviewer: Jason Grout, Karl-Dieter Crisman | Merged:
Work_issues: |
------------------------------------------------+---------------------------
Comment(by kcrisman):
Rather than do the spkg thing, I just dropped the appropriate files and
directory exactly where they belonged in the sagenb tree.
A brief tryout against 4.6.2.rc0 just now seems to have resolved the
disappearance issues I had. Right-clicking and 'About' gives the correct
Jmol version.
This needs more testing - I only have a few minutes between classes right
now - but seems okay. The only obvious issue is that when I click the
help, I get that J. Gutow did this in Nov. 2009. That should probably be
changed, since it's now 2011 :)
For positive review, we need at least the following:
1. Testing on FF, Safari, IE
1. Testing on Linux, VM image on Windows, Mac
1. Making a sagenb spkg update that works properly
Related to this last, I am attaching a patch that is NOT the patch one
would apply. Making a new spkg would not be much harder. The point is
that .hgignore has `sagenb/data/jmol` in it, so that the only file that
actually changes there is `jmol` itself, a script. So the new spkg would
have untracked changes in all the java files - probably a good thing, but
worth being aware of. Also, for some reason the way that I dropped the
new files in did something weird, so that
`sagenb/data/sage/js/jmol_lib.js` ends up only having +, not -, in its
diff.
Also, I am going to post on sage-notebook to ask to just allow sagenb
development on Trac for now. No one has used the Google site except the
author of this update! Too confusing for now.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9238#comment:52>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
