#9960: require SAGE_CHECK to be "yes"
---------------------------------------------+------------------------------
Reporter: jhpalmieri | Owner: was
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7
Component: user interface | Keywords:
Author: John Palmieri, Leif Leonhardy | Upstream: N/A
Reviewer: Leif Leonhardy | Merged:
Work_issues: |
---------------------------------------------+------------------------------
Description changed by jhpalmieri:
Old description:
> Right now, setting SAGE_CHECK to any nonempty string (e.g., "no") runs
> the test suite. The documentation actually says that SAGE_CHECK should
> be "yes" for this to happen. Fix this.
>
> While we're at it, fix something else: in the script SAGE_ROOT/local/bin
> /sage-env, SAGE64 is required to be "yes", "no", or unset:
> {{{
> if [ "$SAGE64" != "yes" -a "$SAGE64" != "no" ]; then
> echo "The environment variable SAGE64 (=$SAGE64) must be either
> unset, yes or no."
> exit 1
> fi
> }}}
> The problem is, whenever sage-env is run, output is redirected to
> /dev/null, so this error message isn't printed. So for example:
> {{{
> $ export SAGE64='maybe'
> $ sage
> $
> }}}
> Sage fails to run and is completely silent as to why. Fix this, too.
>
> ----
>
> Also, due to a bug in `sage-spkg`, successful test suite runs never get
> logged in `spkg/installed/<package-name>` as they should (or is
> intended); this is fixed by the reviewer patch.
>
> (Note that test suite '''failures''' cannot be logged in these files as
> they get deleted on non-successful builds, which [currently] includes
> successful builds with failing self-tests.)
New description:
Right now, setting SAGE_CHECK to any nonempty string (e.g., "no") runs the
test suite. The documentation actually says that SAGE_CHECK should be
"yes" for this to happen. Fix this.
While we're at it, fix something else: in the script SAGE_ROOT/local/bin
/sage-env, SAGE64 is required to be "yes", "no", or unset:
{{{
if [ "$SAGE64" != "yes" -a "$SAGE64" != "no" ]; then
echo "The environment variable SAGE64 (=$SAGE64) must be either unset,
yes or no."
exit 1
fi
}}}
The problem is, whenever sage-env is run, output is redirected to
/dev/null, so this error message isn't printed. So for example:
{{{
$ export SAGE64='maybe'
$ sage
$
}}}
Sage fails to run and is completely silent as to why. Fix this, too.
----
Also, due to a bug in `sage-spkg`, successful test suite runs never get
logged in `spkg/installed/<package-name>` as they should (or is intended);
this is fixed by the reviewer patch.
(Note that test suite '''failures''' cannot be logged in these files as
they get deleted on non-successful builds, which [currently] includes
successful builds with failing self-tests.)
-----
Apply only [attachment:trac_9960-scripts-SAGE_CHECK.v2.patch] (to the
scripts repo).
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9960#comment:48>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
