#9960: require SAGE_CHECK to be "yes"
---------------------------------------------------------+------------------
Reporter: jhpalmieri | Owner: was
Type: defect | Status:
needs_work
Priority: major | Milestone:
sage-4.7
Component: user interface | Keywords:
Author: John Palmieri, Leif Leonhardy | Upstream: N/A
Reviewer: Leif Leonhardy, Ivan Andrus, David Kirkby | Merged:
Work_issues: |
---------------------------------------------------------+------------------
Comment(by drkirkby):
Replying to [comment:53 jdemeyer]:
> I get an error when building sage from scratch (but I'm not entirely
sure this patch is the cause):
And there was me thinking a very small patch John submitted 6 months ago
was finally going to be merged!
I think Leif should '''seriously''' consider the implications of the
endless changes he wants on tickets like this one - changes that are not
related to the problem the ticket is supposed to address.
In many ways I wish all sage developers were as fussy as Leif, as his
approach does generally result in improved quality of code. Many of the
bugs in Sage would not be there if more people were fussy about code that
is written. I cringe at some of the stuff I see written. But Leif's
endless requested changes are slowing Sage development to a crawl.
#9603 took a couple of months to get a positive review on what was
originally a 3 or 4 line patch that was only applied on AIX.
The cliquer package is a complete mess, so I opened a ticket to clean it
up (#9870), and another (#9871) to address an important single issue for a
64-bit Solaris port. The latter took ages, due to unrelated changes
requested by Leif. Then Leif decided to take ownership of the cleanup
patch (#9870), but has done nothing about it in 7 months, despite a couple
of reminders from me.
Not only do these endless changes take longer to implement for the author,
but it makes review so much more difficult. Whereas I would have been
happy to give a positive review to John's original patch, this has become
so complex it is a nightmare reviewing it.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9960#comment:54>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
