#10818: EclLib should allow signals to make LISP code interruptable
------------------------------------------+---------------------------------
   Reporter:  nbruin                      |       Owner:  was                   
   
       Type:  defect                      |      Status:  needs_review          
   
   Priority:  major                       |   Milestone:  sage-4.7              
   
  Component:  interfaces                  |    Keywords:  lisp ecl signal 
interrupt
     Author:  Nils Bruin, Jeroen Demeyer  |    Upstream:  N/A                   
   
   Reviewer:                              |      Merged:                        
   
Work_issues:                              |  
------------------------------------------+---------------------------------

Comment(by nbruin):

 Replying to [comment:16 jdemeyer]:
 > It would be good to include this patch before #7377.  Nils, are you able
 to review this?
 No, sorry. I'm currently not set up to apply and test patches. I gave your
 code a quick look and it looks great

  * The fact that ecl_sig_on() is a macro will work great with Juanjo's
 refinement later

  * I'm a little puzzled that ecl_sig_off() is not a macro. Doesn't the
 same argument apply there?
 (certainly if we apply Juanjo's suggestion it will have to be, because I
 think there is a macro pair that involves straddling "{" and "}").
 However, if the current code works that that is fine. We can always change
 it later.

  * Jeroen is almost certainly more of an expert in Posix signal handling
 than I am. Take that as a recommendation.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10818#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to