#11170: add an ffmpeg option to the animate command
-----------------------------+----------------------------------------------
   Reporter:  jhpalmieri     |       Owner:  jason, was  
       Type:  enhancement    |      Status:  needs_review
   Priority:  minor          |   Milestone:  sage-4.7.1  
  Component:  graphics       |    Keywords:              
     Author:  John Palmieri  |    Upstream:  N/A         
   Reviewer:  David Kirkby   |      Merged:              
Work_issues:                 |  
-----------------------------+----------------------------------------------

Comment(by jhpalmieri):

 Replying to [comment:6 drkirkby]:
 > My point was that even if the exact details of the animation changed
 from version to version, I would not expect the size to vary much. So
 perhaps checking the number of KB (or even MB of the file) would give a
 reasonable confidence the program is producing an mpeg file of about the
 right length.

 For either ffmpeg or !ImageMagick by themselves, this might be right, but
 ffmpeg produces GIFs which are larger (by a fair amount) than !ImageMagick
 does, it seems to me in my limited testing.

 > Two obvious things are different can be seen.
 >
 >  * The Mathematica example uses two hypens, your example uses one.
 >  * The Mathematica example uses all lower case, despite Wolfram Research
 use an upper case M at the start. Your example uses the proper case for
 !ImageMagick
 >
 > '''IF''' this means that one needs to specify how to run the Mathematica
 and !ImageMagick tests differently, then I think that's a bad idea. But
 I've got no idea what is considered "right" in sage, but I think we should
 at least be consistent.
 >
 > I suspect the most robust solution is for the code to accept either case
 - i.e. convert all to lower case, then accept that. Then it would not
 matter what the user typed. Again outside this ticket, but if it has been
 agreed to use all lower case, then perhaps you should use that).

 The script sage-doctest (which is written in python -- sorry) strips all
 hyphens from the comments after each doctest, and converts both the
 comment and the command-line argument to lower case, so this is not a
 problem.  I remember fixing this problem a while ago, and I just double-
 checked the script to be sure.  Also, running with {{{-only-
 optional=imagemagick}}} runs the doctests, despite the difference in case.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11170#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to