#11170: add an ffmpeg option to the animate command
----------------------------+-----------------------------------------------
   Reporter:  jhpalmieri    |          Owner:  jason, was   
       Type:  enhancement   |         Status:  needs_review 
   Priority:  minor         |      Milestone:  sage-4.7.1   
  Component:  graphics      |       Keywords:               
Work_issues:                |       Upstream:  N/A          
   Reviewer:  David Kirkby  |         Author:  John Palmieri
     Merged:                |   Dependencies:               
----------------------------+-----------------------------------------------
Changes (by jhpalmieri):

  * status:  needs_work => needs_review


Comment:

 Replying to [comment:10 ddrake]:
 > This looks very good, and I'm excited to get it in. I do see one tiny
 problem: in the `ffmpeg()` function, line 524, you import `have_program`
 but don't use it -- that's the job of `self._have_ffmpeg()`. So I think
 you can delete line 524.

 Done -- here's a new patch.  I also rebased it against 4.7.rc1 -- there
 were some changes to the same parts of the installation guide, so the old
 version wasn't applying cleanly.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11170#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to