#11028: More Modular ComplexPlot
---------------------------+------------------------------------------------
Reporter: evanandel | Owner: jason, was
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-4.7
Component: graphics | Keywords: complex plot riemann map
Work_issues: | Upstream: N/A
Reviewer: | Author: evanandel
Merged: | Dependencies:
---------------------------+------------------------------------------------
Comment(by evanandel):
You're absolutely right about the patch issues. I'm not sure how it got
doubled... The top half, with the actual test cases is more current, those
methods should be testing properly. Also, the redundant changes seem to be
a slightly older version of my error handling, I'm not sure why they're in
this one. I'm going to try and fix up the patch manually.
With regards to complex_to_rgb, there are two versions because Riemann
assigns colors slightly differently than complex_plot. Thus the methods
really are intentionally somewhat different. Also, I don't think we need a
deprecation period for the complex_to_rgb or ComplexPlot calls. That seems
to a fairly specific internal method for complex_plot. I have a hard time
imagining someone else using that stuff without going through
complex_plot() which has been changed appropriately.
That said, I don't know what the official policy is on such matters.
Robert Bradshaw could probably give a better answer as to whether the
changes will break anything.
Finally, I'm not sure what you mean by the better docs for ColorPlot. What
specifically are you referring to?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11028#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
