#11316: Weighted degree term orders added
--------------------------------+-------------------------------------------
   Reporter:  klee              |          Owner:  AlexGhitza  
       Type:  enhancement       |         Status:  needs_review
   Priority:  major             |      Milestone:  sage-4.7.1  
  Component:  basic arithmetic  |       Keywords:              
Work_issues:                    |       Upstream:  N/A         
   Reviewer:                    |         Author:  Kwankyu Lee 
     Merged:                    |   Dependencies:              
--------------------------------+-------------------------------------------

Comment(by SimonKing):

 In the third patch, all double underscore attributes are renamed into
 single underscore attributes -- including old attributes.

 While the simple addition of one attribute is no substantial change of
 data structure, changing `__name` into `_name` etc certainly ''is''. That
 undoubtedly makes unpickling more complicated, to the extent that
 introducing `_weights` as a class attribute would not suffice anymore.
 With that patch, there is probably no way around using `__setstate__`.

 The good news is: A block order pickled with `sage-4.6.2` can be read with
 the third patch.

 I think we agree that we don't like double underscore so much. The
 question is: Should our dislike be reason enough to change it, if the
 price to pay is an unpickling that could certainly be simpler without
 changing the old names? Or would that be shooting ourselves in the foot?

 If we wish unpickling to be easy then the further work should be based on
 the second patch, with `__setstate__` removed or at least simplified
 (namely without creating a temporary term order). If we wish to get rid of
 double underscore attributes (including the old ones) then I guess there
 is no short elegant way of preserving backward compatibility.

 I'd like to know the opinion of Martin and/or Burcin on that point.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11316#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to