#11316: Weighted degree term orders added
--------------------------------+-------------------------------------------
Reporter: klee | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: basic arithmetic | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Kwankyu Lee
Merged: | Dependencies:
--------------------------------+-------------------------------------------
Comment(by klee):
There is more change in the logic than mere adding one attribute, Simon.
In the old TermOrder, the `__name` attribute essentially contains all
information in string form about the term order. For example, `__name` is
``lex(2),degrevlex(3)`` for a block order. This is a convenient
representation for Singular. In new TermOrder, `__name` is just ``block``
and `__blocks` contain `TermOrder(`lex`,2)` and
`TermOrder(`degrevlex`,3)`. (I think the old TermOrder is somewhat
Singular-centric, which may be justified since Sage heavily relies on
Singular.) You could appreciate the amount of change in logic only after
reading the old TermOrder class. Adding just `__weights=None` when
unpickling old `TermOrder(``lex(2),degrevlex(3)``) will result in
unpickling failure. I hope Martin come up and confirm this.
I will not further insist on my proposal of the unpickling infrastructure.
Perhaps the issue will rise again if that is really necessary.
The third patch applies cleanly to Sage 4.7 and there is no doctest
failure. On my part, the patch is quite satisfactory and the unpickling
problem is elegantly solved. :-) So I feel no need to spend more time on
this.
As Burcin suggested, if this patch would be merged to Sage, we have to
mention for breaking backward compatibility (by removing `block`
attribute) in the release notes.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11316#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
