#11316: Weighted degree term orders added
--------------------------------+-------------------------------------------
Reporter: klee | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: basic arithmetic | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Kwankyu Lee
Merged: | Dependencies:
--------------------------------+-------------------------------------------
Comment(by SimonKing):
Hi Kwankyu,
Replying to [comment:23 klee]:
> There is more change in the logic than mere adding one attribute, Simon.
Yep, meanwhile I noticed it (see my previous post), and also I got more
sleep.
> Adding just `__weights=None` when unpickling old
`TermOrder(``lex(2),degrevlex(3)``) will result in unpickling failure. I
hope Martin come up and confirm this.
I can confirm it as well.
I found that adding `_weights=None` and `_blocks=()` made it possible to
read old pickles even without `__setstate__`, but then the semantical
change of `_name` and `blocks` struck.
> The third patch applies cleanly to Sage 4.7 and there is no doctest
failure. On my part, the patch is quite satisfactory and the unpickling
problem is elegantly solved. :-) So I feel no need to spend more time on
this.
I still find it awkward to create a temporary term order in
`__setstate__`. However, it works.
> As Burcin suggested, if this patch would be merged to Sage, we have to
mention for breaking backward compatibility (by removing `block`
attribute) in the release notes.
In the release notes and also in the documentation.
There would be the possibility to find a different name than `blocks()` in
order to avoid a name conflict with an old attribute. But I think
`blocks()` is a better name than, e.g., `block_list()`.
So, for now, I have no objections against the third patch version. I'll
probably give it a positive review after reading it thoroughly (including
the documentation) and running the doctests.
For the patchbot:
Apply trac_11316.3.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11316#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
