#11431: Conversion from Singular to Sage
-------------------------------+--------------------------------------------
   Reporter:  SimonKing        |          Owner:  was       
       Type:  defect           |         Status:  needs_work
   Priority:  major            |      Milestone:  sage-4.7.1
  Component:  interfaces       |       Keywords:            
Work_issues:                   |       Upstream:  N/A       
   Reviewer:  Martin Albrecht  |         Author:  Simon King
     Merged:                   |   Dependencies:  #11316    
-------------------------------+--------------------------------------------

Comment(by SimonKing):

 Replying to [comment:4 SimonKing]:
 > ...
 > >  * Can you also fix "If it is provided, then you *must* take care OFF
 it."?
 >
 > Why "off"? With two f?
 >
 > Wouldn't it be correct English to say "If it is provided, then you must
 take care that it matches the current ring in Singular"? (i.e., I forgot
 the "that" in my patch)

 Perhaps not. But "If it is provided, then you have to make sure that it
 matches..." is fine, isn't it?

 > >  * shouldn't {{{TermOrder_from_Singular}}} be lower-case since it's a
 function? Or were you aiming for upper-case because it's a constructor?
 >
 > I made it upper case because it returns a `TermOrder` (that is how the
 class is called). But actually I was ignorant to the convention that
 functions are lower-case. So I'll change it.
 >
 > >  * In "Invalid termorder in Singular" shouldn't it be term order, i.e.
 with a space?
 >
 > Yep!
 >

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11431#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to