#11431: Conversion from Singular to Sage
-------------------------------+--------------------------------------------
Reporter: SimonKing | Owner: was
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.7.1
Component: interfaces | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Martin Albrecht | Author: Simon King
Merged: | Dependencies: #11316
-------------------------------+--------------------------------------------
Comment(by SimonKing):
Hi Martin!
Replying to [comment:3 malb]:
> * can we rename {{{sage_basering}}} to {{{sage_global_ring}}}. In Sage
{{{base_ring}}} has a special meaning which is not meant in your patch. I
think global ring captures it.
Sounds fine to me. Obviously I took the name `sage_basering` from
Singular, but you are right that it might be confusing for people who know
the notion `base ring` only from Sage.
> * don't real fields also have a precision in Singular?
Right, that should be taken care of as well.
> * Can you also fix "If it is provided, then you *must* take care OFF
it."?
Why "off"? With two f?
Wouldn't it be correct English to say "If it is provided, then you must
take care that it matches the current ring in Singular"? (i.e., I forgot
the "that" in my patch)
> * shouldn't {{{TermOrder_from_Singular}}} be lower-case since it's a
function? Or were you aiming for upper-case because it's a constructor?
I made it upper case because it returns a `TermOrder` (that is how the
class is called). But actually I was ignorant to the convention that
functions are lower-case. So I'll change it.
> * In "Invalid termorder in Singular" shouldn't it be term order, i.e.
with a space?
Yep!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11431#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
