#11431: Conversion from Singular to Sage
-------------------------------+--------------------------------------------
Reporter: SimonKing | Owner: was
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: interfaces | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Martin Albrecht | Author: Simon King
Merged: | Dependencies: #11316
-------------------------------+--------------------------------------------
Changes (by SimonKing):
* status: needs_work => needs_review
Comment:
I've put my changes into the second patch, so, please replace that when
you test it.
''Names'': I changed `sage_basering` into `sage_global_ring` and
`TermOrder_from_Singular` into `termorder_from_singular`.
''Precision'': Singular does not tell the precision of a real field in
`charstr()`, it does so only for complex fields. But the precision both of
real and complex fields is part of `ringlist()`. So, both in the real and
the complex case, I take the precision from there, not from `charstr()`.
''Grammar'': It is now "Invalid term order" (not "termorder") and "If it
is provided, then you have to make sure that it matches..." (not "If it is
provided, then you *must* take care it matches...")
''Tests'': Of course I added a test showing that the precision of real
fields is taken care of. And it turned out that one doctest needed a fix,
because when I created it I used a different term order (so that the same
polynomial was printed in a different way).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11431#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
