#11530: PARI initialization of finite field elements mangles Mod
-----------------------+----------------------------------------------------
Reporter: rbeezer | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: algebra | Keywords: _pari_init_, variable name, finite
field
Work_issues: | Upstream: N/A
Reviewer: | Author: Simon King
Merged: | Dependencies:
-----------------------+----------------------------------------------------
Changes (by newvalueoldvalue):
* keywords: => _pari_init_, variable name, finite field
* status: new => needs_review
* author: => Simon King
Comment:
My patch completely avoids the string replacement.
If a variable name is given, it replaces
`self.parent()._finite_field_ext_pari_modulus_as_str()` by
`repr(self.parent().modulus()._pari_with_name(var))`, and
`self.polynomial()` allows to change the variable name as well, so, I use
`self.polynomial(var)` instead.
Of course I added a test, and the tests of
`sage/rings/finite_rings/element_givaro.pyx` pass. I didn't run full
tests, yet, but I think it is ready for review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11530#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
